[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

[The Wanderer]

Dominik 'Rathann' Mierzejewski wrote:

> On Monday, 05 December 2005 at 17:55, The Wanderer wrote:
> 
>> Dominik 'Rathann' Mierzejewski wrote:

>>> Well, both Reimar and Roberto seemed to accept it. Only Rich
>>> objected.
>> 
>> And I'm reluctant to commit something to which one of the relevant
>> developers objects unless there is a consensus that that
>> developer's views should be overruled. Since Rich is not only one
>> of the "big-name" developers but the person most likely to revert a
>> change he objects strongly to, the matter is if anything worse in
>> the case at hand.
> 
> Well, he has a point, too. Return values may come useful in the
> future even if we don't use them now. I'd say drop it and call for
> someone to write a patch _adding_ those to all demuxers. ;)

I'd tend to agree - I have something of a habit, when writing my own
programs, of using the return value of any function which could be void
as a type of error code (and, then, testing (and frequently cascading
returns on) the value returned by every call of that function), and
while it can be a little unwieldy to take adantage of it can also be
useful for catching problems.

In the absence of dissenting opinions, consider the patch dropped.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.