[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

[Dominik 'Rathann' Mierzejewski]

On Monday, 05 December 2005 at 17:55, The Wanderer wrote:
> Dominik 'Rathann' Mierzejewski wrote:
> 
> >On Monday, 05 December 2005 at 03:39, The Wanderer wrote:
> >
> >>Thanks. Now, what about the rest of the 'mplayer-demuxers' patch?
> >>Should it be considered dropped (at least pending another patch
> >>submission), or is it still potentially viable?
> >
> >Well, both Reimar and Roberto seemed to accept it. Only Rich
> >objected.
> 
> And I'm reluctant to commit something to which one of the relevant
> developers objects unless there is a consensus that that developer's
> views should be overruled. Since Rich is not only one of the "big-name"
> developers but the person most likely to revert a change he objects
> strongly to, the matter is if anything worse in the case at hand.

Well, he has a point, too. Return values may come useful in the future
even if we don't use them now. I'd say drop it and call for someone to
write a patch _adding_ those to all demuxers. ;)

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"