[MPlayer-dev-eng] [PATCH] demuxers cleanup (was Re: [PATCH] misc small fixes (mostly gcc warnings) )

[Rich Felker]

On Mon, Dec 05, 2005 at 11:55:40AM -0500, The Wanderer wrote:
> Dominik 'Rathann' Mierzejewski wrote:
> 
> >On Monday, 05 December 2005 at 03:39, The Wanderer wrote:
> >
> >>Thanks. Now, what about the rest of the 'mplayer-demuxers' patch?
> >>Should it be considered dropped (at least pending another patch
> >>submission), or is it still potentially viable?
> >
> >Well, both Reimar and Roberto seemed to accept it. Only Rich
> >objected.
> 
> And I'm reluctant to commit something to which one of the relevant
> developers objects unless there is a consensus that that developer's
> views should be overruled. Since Rich is not only one of the "big-name"
> developers but the person most likely to revert a change he objects
> strongly to, the matter is if anything worse in the case at hand.

I won't reverse r flame. This issue doesn't break MPlayer for me or
other users like some of the changes I reversed. However I still do
believe it reduces functionality and readability of the code and makes
it more difficult to add result checking in the future. I'd rather we
add return values to all demuxers, even if we won't check them for
now, than remove all the return values.

Rich