[MPlayer-dev-eng] [PATCH] support for external VIDIX

[Diego Biurrun]

On Mon, Mar 27, 2006 at 11:34:12PM +0200, Nico Sabbi wrote:
> Diego Biurrun wrote:
> 
> >On Sun, Mar 26, 2006 at 11:32:45PM +0200, Nico Sabbi wrote:
> > 
> >>Diego Biurrun wrote:
> >>
> >Huh?  Both variables are 'no' to begin with then, why do you need to set
> >one to 'no' again?
> >
> Patched updated.
> IIUC what you mean the issues you complained about should be fixed,

Yes, it's much better.

> anyway I'm no more so sure that supporting external vidix is a good idea:

Support for external VIDIX is helpful IMO.

> --- configure	21 Mar 2006 05:36:09 -0000	1.1149
> +++ configure	27 Mar 2006 21:21:31 -0000
> @@ -7133,9 +7137,35 @@
>  
> +echocheck "VIDIX (external)"
> +if test "$_vidix_internal" = no && test "$_vidix_external" != no; then

Only make the test if _vidix_external is set to auto.

> +if test "$_vidix_internal" = yes || test "$_vidix_external" = yes ; then

"test A -o B" is simpler and faster.

Diego