[MPlayer-dev-eng] [PATCH] new mpeg muxer

[D Richard Felker III]

On Sun, Feb 27, 2005 at 09:37:24AM +0100, Nico Sabbi wrote:
> D Richard Felker III wrote:
> 
> >>>     
> >>>
> >>attached is a first implementation of your algorithm.
> >>
> >>:telecine sets only fps, tff and rff; :telecine2 also sets progressive 
> >>sequence to 0.
> >>
> >>I asked Billy to help me but I haven't received any answer, yet.
> >>
> >>Testreports are welcome.
> >>
> >>  Nico
> >>   
> >>
> >
> >comitted. if we find anything wrong we can fix it later, but this
> >seems to be working fine.
> >
> >rich
> >
> > 
> >
> 
> good, but which one did you use: telecine or telecine2 ?

I just tested the output with MPlayer, not any hardware. I don't think
I have access to any hardware that's picky enough to care..

For the reference, telecine2.

> I still have two doubts.
> 1) at the moment telecining is applied to frames in decoding order:
> to me it seems natural to apply it to frames in display order, or is it 
> wrong?

Yes...this is a major problem, dammit. I've said it 1000 times it
feels like, but I'll say once again: I FUCKING HATE B FRAMES!!!!!!!

Whoever came up with such idiocy should be tied to heavy rocks and
thrown into a huge vat of cola!!

> 2) actually timestamps are not modified after telecining, but wouldn't 
> the player
> get momentarily out of sync in the course of a second (although the user 
> might not nitice)?
> Should I recalculate frame duration and pts after telecining?

Perhaps. MPEG pts handling is really broken and I don't understand it,
so I'll leave it up to you or someone else to figure it out. If you
can find an easy way to do it, it probably should be done.

Rich