[MPlayer-dev-eng] [PATCH] charset conversion for help messages

[Reimar Döffinger]

Hi,
On Sat, Feb 19, 2005 at 03:04:59PM +0100, Torinthiel wrote:
> On Sat, Feb 19, 2005 at 12:40:20PM +0100, Reimar Döffinger wrote:
> > What do you think of this? It is a really small patch, and I think this
> > is quite useful, especially as I think we really should support utf8 -
> > it seems the only useable charset to me.
> 
> Not to me, but I agree it would be usefull and nice to have.

Well, it is the only charset that works if you use several, especially
non-european languages...

> What I'd like even more is some kind of autodetection of output charset
> (based on LC_* settings), which of course could be overridden by
> --charset. And also if *.charset is missing default to ISO-8859-1.

Detection based on LC_* settings seems very unreliable, as well as
defaulting to ISO... Getting a .charset file should be no problem for
all languages that are actively maintained...

> Also, if we already have charset stored somewhere then why not convert
> manpages on installing? (with some care, not to convert KOI8-R to
> ISO-8859-2 for example).

I don't know, is this neccessary? I though maybe man can take care of
that...

> > Index: configure
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/configure,v
> > retrieving revision 1.964
> > diff -u -r1.964 configure
> > --- configure	18 Feb 2005 03:55:27 -0000	1.964
> > +++ configure	19 Feb 2005 11:35:18 -0000
> > @@ -1383,6 +1385,7 @@
> >  #_language=en
> >  _shm=auto
> >  _linux_devfs=no
> > +#_charset=utf8
> 
> What is this for? I don't think this should have a default, and not
> a commented out one for sure.

Yes, it has a default (empty), which means do no conversion, just as
configure currently behaves...

Greetings,
Reimar Döffinger