[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

[Diego Biurrun]

Oded Shimon writes:
> 
> And, no offense to Reynaldo, but are you sure you are the best dev to be 
> dealing with this patch?... I think it would be better if someone with more 
> experience with mencoder.c would deal with it, but so far nobody except you 
> has been answered... Again, no offense meant to you Reynaldo, I'm grateful 
> you went over my e-mail/patch :)

Oded, if you follow dev-eng and see the amount of patches we get and
how little response they get on average you should really be grateful
that this is not happening to (most of) your patches.

Getting a patch reviewed and committed depends on somebody taking
interest in your patch, looking it through and making suggestions for
improvements.  Among the developers that have CVS write access some
are clearly in charge of parts of MPlayer and the others won't touch
their area without permission.  There are other parts of MPlayer
without a clear and active maintainer.  Here the rules are more free
and basically anybody can take decisions as long as he is willing to
share some of the Cola with the patch sender.  MEncoder is such a
largely unmaintained part of MPlayer.  Reynaldo stepped up to the task
of reviewing your patch.  Of course there are differences between the
developers, some are more experienced than others.  Reynaldo has not
been on this project for a long time and he will probably discuss your
patch with others before (if) he applies it.  That does not make his
review any less valuable for you, on the contrary.  I can assure you
that the more experienced devs will probably not bother looking at
your patch before you haven't addressed whatever he had to criticize.
If and when you have done that the chances of somebody else going over
your patch and giving his final OK will have vastly increased since
the first review should have caught the obvious mistakes, making a
second review less time consuming.

Diego