[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

[The Wanderer]

Diego Biurrun wrote:

> Message review as requested..
> 
> Oded Shimon writes:
> 
>> +#define MSGTR_ResolutionDoesntMatch "\nNew video file's reolution doesn't match previous!\n"
> 
> New video file has different resolution than the previous one.

I'm given to understand that "different ... than" is not a valid
grammatical construction ("different from" is preferred, but frequently
requires rephrasing), and in any case, spelling errors aside this
suggestion seems clunkier and more awkward to me than the previous form.

>> +#define MSGTR_FrameCopyFileMismatch "\nAll video files must be identical in fps, resolution, and codec in -ovc copy!\n"
> 
> All video files must have identical fps, resolution, and codec for
> -ovc copy.

This works.

>> +	if (!stream) {
>> +		mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_CannotOpenFile_Device);
>> +		mencoder_exit(1,NULL);
> 
> You'll have to set correct MSGT and MSGL here. MSGL_FATAL seems
> appropiate since you exit the program afterwards. I think MEncoder
> uses MSGT_CPLAYER generally.
> 
>> +	mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_OpenedStream, file_format, (int)(stream->start_pos), (int)(stream->end_pos));
> 
> Dunno which MSGL to apply here, but you have to change it from
> FIXME.

Yes - FIXME are intended for use only when converting to mp_msg from
printf. (Says the man who hasn't done any of that in far too long...)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.