[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

[Diego Biurrun]

Message review as requested..

Oded Shimon writes:
> 
> +#define MSGTR_ResolutionDoesntMatch "\nNew video file's reolution doesn't match previous!\n"

New video file has different resolution than the previous one.

> +#define MSGTR_FrameCopyFileMismatch "\nAll video files must be identical in fps, resolution, and codec in -ovc copy!\n"

All video files must have identical fps, resolution, and codec for -ovc copy.

> +	if (!stream) {
> +		mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_CannotOpenFile_Device);
> +		mencoder_exit(1,NULL);

You'll have to set correct MSGT and MSGL here.  MSGL_FATAL seems
appropiate since you exit the program afterwards.  I think MEncoder
uses MSGT_CPLAYER generally.

> +	mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_OpenedStream, file_format, (int)(stream->start_pos), (int)(stream->end_pos));

Dunno which MSGL to apply here, but you have to change it from FIXME.

> +	if(!demuxer){
> +		mp_msg(MSGT_DEMUXER,MSGL_ERR,MSGTR_FormatNotRecognized);
> +		mp_msg(MSGT_DEMUXER, MSGL_ERR, MSGTR_CannotOpenDemuxer); //correct target/level? FIXME?
> +		mencoder_exit(1,NULL);

Since you abort the program I think MSGL_FATAL would be right.

> +	if(!sh_video)
> +	{
> +		mp_msg(MSGT_CPLAYER,MSGL_FATAL,MSGTR_VideoStreamRequired); 
> +		mencoder_exit(1,NULL);

same here

> +	if(!video_read_properties(sh_video)){
> +		mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_CannotReadVideoProperties);
> +		mencoder_exit(1,NULL);

and here

> +	if (out_file_format == MUXER_TYPE_MPEG) {
> +		if (audio_preload > 0.4) {
> +			mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_LimitingAudioPreload);
> +			audio_preload = 0.4;
> +		}
> +		if (audio_density < 4) {
> +			mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_IncreasingAudioDensity);
> +			audio_density = 4;
> +		}
> +	}
> +	
> +	if(file_format == DEMUXER_TYPE_TV) {
> +		mp_msg(MSGT_FIXME, MSGL_FIXME, MSGTR_ZeroingAudioPreloadAndMaxPtsCorrection);
> +		audio_preload = 0.0;
> +		default_max_pts_correction = 0;

These also need to be fixed.

Diego