[MPlayer-dev-eng] [PATCH] Fix vf_expand aspect when d_width != width

[Rich Felker]

On Mon, Dec 05, 2005 at 07:47:51AM +0200, Oded Shimon wrote:
> On Sun, Dec 04, 2005 at 11:38:01PM -0500, Jason Tackaberry wrote:
> > The attached patch fixes vf_expand so that when specifying an aspect
> > ratio, it accounts for hardware scaling (or, more accurately, when
> > d_width != width) so that the final display resolution is the
> > user-specified aspect ratio.
> > 
> > For example, I have a movie with a frame size of 704x368 and an aspect
> > ratio of 2.271, so that the display size would be 836x368.  Without this
> > patch, specifying -vf expand=:::::4/3 would cause a frame size of
> > 704x528 and a display size of 836x528 (because 704/(4/3) = 528), which
> > is not the aspect given (1.583 != 1.333).  With this patch, the expand
> > height takes into account the display aspect, so the expanded frame size
> > is 704x627 and display size of 836x627 (which is 4/3).
> 
> It should possibly be optional?

I don't see why. The current behavior is never correct unless pixels
are square. I'm in favor of applying this patch. If you can point out
a case where it needs to be optional feel free to commit another patch
to make it optional, but this patch should be the default behavior.

Rich