[MPlayer-users] Patches for changing indentation accepted?

Brian J. Murrell d3a0a4f18165de75cc2cfe1edb9a1e55 at interlinx.bc.ca
Sun May 5 16:53:01 CEST 2002


On Sun, May 05, 2002 at 03:04:08PM +0200, Fredrik Kuivinen wrote:
> 
> I agree with all your points. Having this 'no cosmetic changes' rule
> makes the code go into a unreadable state IMHO.

I will chime in agreement here as well.  Having just been through some
fo the code for hacking it, I can say that trying to understand where
blocks of code are toghether is next to impossible.  Yeah, it can be
done, tracing braces and the like but what a waste of time.

There are some common, basic, indenting styles that you will find in
90+% of code out there, that makes it easier to read and understand.
Why adopt a least a common ground of them.  I don't really care where
braces go (on the same line, next line, etc) or whether case clauses
of a switch statement are indented or not but some standard indenting
(every enclosing block indent by one tabstop) at a minimum would be
nice.

I just see this as more of the old "the developers are the elite"
theme here.

b.

-- 
Brian J. Murrell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20020505/bb5748d6/attachment.pgp>


More information about the MPlayer-users mailing list