[MPlayer-dev-eng] [PATCH] fix compilation on intel mac
Martin Simmons
vyslnqaaxytp at spammotel.com
Sun Mar 26 01:39:43 CET 2006
>>>>> On Wed, 22 Mar 2006 07:58:33 -0500, Nicolas Plourde <nicolas.plourde at gmail.com> said:
> Hi Guys, Here is my first attempt at a intel mac patch for mplayer.
> Currently libavcodec and mp3lib are still not compilling.
> Index: configure
> ===================================================================
> RCS file: /cvsroot/mplayer/main/configure,v
> retrieving revision 1.1149
> diff -u -r1.1149 configure
> --- configure 21 Mar 2006 05:36:09 -0000 1.1149
> +++ configure 22 Mar 2006 12:49:41 -0000
> @@ -7028,7 +7028,11 @@
> echores "$_crash_debug"
> if darwin ; then
> + if x86 ; then
> + CFLAGS="$CFLAGS -DSYS_DARWIN"
> + else
> CFLAGS="$CFLAGS -mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN"
> + fi
> fi
I wonder, if -falign-loops=16 is not wanted/needed, why all the effort to make
.balign/.align work?
> Index: mangle.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/mangle.h,v
> retrieving revision 1.6
> diff -u -r1.6 mangle.h
> --- mangle.h 30 Mar 2003 20:11:05 -0000 1.6
> +++ mangle.h 22 Mar 2006 12:49:41 -0000
> @@ -9,7 +9,7 @@
> /* Feel free to add more to the list, eg. a.out IMO */
> #if defined(__CYGWIN__) || defined(__MINGW32__) || defined(__OS2__) || \
> - (defined(__OpenBSD__) && !defined(__ELF__))
> + (defined(__OpenBSD__) || defined(__APPLE__) && !defined(__ELF__))
I think this should be
(defined(__OpenBSD__) && !defined(__ELF__)) || defined(__APPLE__)
otherwise it will be true for all __OpenBSD__ systems (and I assume Apple is
never ELF).
__Martin
More information about the MPlayer-dev-eng
mailing list