[MPlayer-dev-eng] [PATCH] X264_* & X264_* vars broken
Diego Biurrun
diego at biurrun.de
Thu Mar 23 14:48:02 CET 2006
On Wed, Mar 22, 2006 at 02:59:02PM -0600, Derek E. Lewis wrote:
> Users who install XviD or x264 into non-default locations will experience
> broken builds when building libavcodec/, as ffmpeg does not use XVID_INC,
> XVID_LIB, X264_INC, and X264_LIB. XVID_INC and friends are specified
> using --with-xvid* --with-x264*, giving a user an impulse to use those
> configure options over --with-extra*. I've relocated the homes of
> $_ld_x264 and $_ld_xvid to EXTRA_LIBS.
OK, not a bad idea.
> We may consider to remove all instances of *_INC and *_LIB in the future,
> as it leaves too much room for inconsistency between MPlayer and ffmpeg.
Yes. Patches welcome.
About this patch, the idea looks good, but:
> --- configure 21 Mar 2006 05:36:09 -0000 1.1149
> +++ configure 22 Mar 2006 20:50:49 -0000
> @@ -2028,24 +2024,12 @@
> --with-dvbincdir=*)
> _inc_dvb=-I`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -I,g'`
> ;;
> - --with-xvidlibdir=*)
> - _ld_xvid=-L`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -L,g'`
> - ;;
> - --with-xvidincdir=*)
> - _inc_xvid=-I`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -I,g'`
> - ;;
> --with-dtslibdir=*)
> _ld_libdts=-L`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -L,g'`
> ;;
> --with-dtsincdir=*)
> _inc_libdts=-I`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -I,g'`
> ;;
> - --with-x264libdir=*)
> - _ld_x264=-L`echo $ac_option | cut -d '=' -f 2 | sed 's,:, -L,g'`
> - ;;
> - --with-x264incdir=*)
> - _inc_x264=-I`echo $ac_option | cut -d '=' -f 2 |sed 's,:, -I,g'`
> - ;;
> --with-sdl-config=*)
> _sdlconfig=`echo $ac_option | cut -d '=' -f 2`
> ;;
> @@ -7267,7 +7251,7 @@
> JPEG = $_mkf_jpg
> GIF = $_mkf_gif
>
> -EXTRA_LIB = $_ld_extra
> +EXTRA_LIB = $_ld_extra $_ld_xvid $_ld_x264
Where are _ld_xvid and _ld_x264 supposed to come from now? You have
removed the code that generated them.
Diego
More information about the MPlayer-dev-eng
mailing list