[MPlayer-dev-eng] [PATCH] if(verbose>X) --> mp_msg_test

Diego Biurrun diego at biurrun.de
Wed Mar 22 08:48:09 CET 2006


On Tue, Mar 21, 2006 at 08:26:21PM -0400, Reynaldo H. Verdejo Pinochet wrote:
> On Wed, Mar 22, 2006 at 12:53:37AM +0100, Diego Biurrun wrote:
> > 
> > I was staring at progress bars a lot at work yesterday, so I did some
> > janitorial work that should help the pending mp_msg patch from attila.
> > 
> > I've converted all the 'if (verbose > X)' calls to mp_msg_test, which is
> > the proper way and gets us rid of a few global vars as an added bonus.
> > 
> > I intend to apply this tomorrow, shout now if I messed up somewhere.
> 
> -if (verbose>1) print_wave_header(mux_a->wf);
> +if ( mp_msg_test(MSGT_MENCODER,MSGL_V) ) print_wave_header(mux_a->wf,
> MSGL_V);
> 
> Shouldnt this one be: mp_msg_test(MSGT_MENCODER,MSGL_DBG2) ?
> 
> I mean:
> 
> if(verbose>0) == mp_msg_test(MSGT_MENCODER,MSGL_V)
> 
> Same here but its commented out so who cares
> 
> +//      if(mp_msg_test(MSGT_CPLAYER,MSGL_V)printf("sleep: %5.3f
> a:%6.3f  v:%6.3f  \n",time_frame,sh_audio->timer,sh_video->timer);
> 
> Havent checked te rest of it yet.

Fixed locally, thanks.

Diego




More information about the MPlayer-dev-eng mailing list