[MPlayer-dev-eng] Re: [PATCH] unrarlib.h 64bits fix
Alban Bedel
albeu at free.fr
Sat Mar 18 16:20:20 CET 2006
On Sat, 18 Mar 2006 15:51:48 +0100
"Guillaume POIRIER" <poirierg at gmail.com> wrote:
> Hi,
>
> On 3/18/06, ybastide <ybastide at wanadoo.fr> wrote:
> > unrarlib.h declares 32 bits UDWORD as unsigned long. This breaks the
> > CRC check.
>
> #ifdef _UNIX /* LINUX/UNIX
> #definitions */
> typedef unsigned char UBYTE;
> typedef unsigned short UWORD;
> -typedef unsigned long UDWORD;
> +typedef unsigned int UDWORD;
> #endif
>
> This patch seems so logical and straightforward that I'm really
> tempted to apply it right away.... but the existing definition seems
> so stupid to me that I can't quite imagine anyone writhing such a
> thing.
>
> ... so I'll way one day before committing it unless someone else think
> it got to be applied right now.
What about converting those to uint[8|16|32]_t and getting rid of the pb
once and for all ?
Albeu
More information about the MPlayer-dev-eng
mailing list