[MPlayer-dev-eng] Re: [PATCH] osd menu like gmlayer

[Alban Bedel]

On Fri, 24 Feb 2006 17:13:23 +0100
Ötvös Attila <oattila at chello.hu> wrote:

> 2006. február 24. 12.24 dátummal Benjamin Zores ezt írta:
> > I just had a quick look at the patch itself and I'm wondering why did you
> > make a new libmpmenu instead of simply extending the existing libmenu one ?
> 
> I am sorry! I bungled it.
> Fixed libmpmenu->libmenu and updated with CVS.
> 
> Implemented Select TV channels.
> 
> http://dcxx.fw.hu/

Hi,

sorry for the late reply but wasn't following the list in the last few weeks.
I took a look at the patch but didn't tested it yet. There seems to be a lot
of very intersting stuff, but it will need some refactoring/rethinking i fear.

Outright the biggest problem is the interfacing with streams (in particular
dvd and vcd). Code specific to a stream type, demuxer, etc doesn't belong
in mplayer.c. Instead new control should be created (like CTRL_GET_TRACK_COUNT
or whatever) and implemented in the stream/demuxer.

However regarding opening medias, i'm thinking it might be more intersting to
implement a generic "directory listing" in the streams. In this way a single
menu could handle browsing the local filesystem, dvd, tv channel list, etc.
Basically the stream/demuxer would just implement a control that return a
directory listing.

For the config saving stuff, it can probably be done in a much simpler way.
This duplicated option list is not a good idea. It should be trivial and
much cleaner to add a simple function to m_config.c to save a list of
options in a file (ie something like: int m_config_save(m_config_t* cfg,
char* filename, char** opts).

Also please try to respect the file naming conventions. Your vd_null.c is not
a video decoder. Such code would belong in dec_video.c i think. Same goes
for null.c, demux_null.c would be better.

	Albeu