[MPlayer-dev-eng] [PATCH 8/11] MPlayer <-> GeeXboX patches port : libmenu Audio/sub/chap change support.

[Nico Sabbi]

Benjamin Zores wrote:

>On Fri, 24 Feb 2006 16:22:35 +0100
>Benjamin Zores <ben at geexbox.org> wrote:
>
>  
>
>>This patch is the biggest one.
>>
>>It adds 3 new applets to libmenu :
>>- Audio channels selection
>>- Subtitle selection
>>- DVD Chapter selection.
>>
>>It also patches Matroska and OGG demuxers (+ DVD streams) to return to libmenu
>>the available number of audio/subs/chapters and allow runtime switching.
>>    
>>
>
>same here, any chance ?
>
>Ben
>
>  
>

as fas as I'm concerned this patch is rejected.
Although I like the idea of adding chapters navigation in the menu I 
believe that
adding global/extern structures is absolutely the wrong thing to do:
it litters even more the code (yes, it's possible :)  ).
You can implement the same functionality adding a new DEMUXER_CTRL for 
every
demuxer involved that should return data in a common structure.