[MPlayer-dev-eng] MPLAYER_VERBOSE environment variable?

[Ivan Kalvachev]

2006/1/17, Oded Shimon <ods15 at ods15.dyndns.org>:
> On Tue, Jan 17, 2006 at 03:07:52AM -0500, Chuck Blake wrote:
> > Index: mp_msg.c
> > ===================================================================
> > RCS file: /cvsroot/mplayer/main/mp_msg.c,v
> > retrieving revision 1.31
> > diff -u -w -r1.31 mp_msg.c
> > --- mp_msg.c  7 Dec 2005 05:12:07 -0000       1.31
> > +++ mp_msg.c  17 Jan 2006 07:30:44 -0000
> > @@ -26,6 +26,9 @@
> >
> >  void mp_msg_init(){
> >      int i;
> > +    char *env = getenv("MPLAYER_VERBOSE");
> > +    if (env)
> > +        verbose = atoi(env);
> >  #ifdef USE_I18N
> >  #ifdef MP_DEBUG
> >      fprintf(stdout, "Using GNU internationalization\n");
>
> I like this, I'm in favor of committing. Is there any portability issues?
> can I commit?..
>
> - ods15

I don't like it.

You can always set verbose option in the ~/.mplayer/config file per
user basis or in global config file. You can override it on invocation
basis with command line.

If we start adding environment variable for every mplayer option (why
not... it is so cute) we will only pollute the already enough polluted
environment.