[MPlayer-dev-eng] [PATCH] support for libXvMCW wrapper library

Ivan Kalvachev ikalvachev at gmail.com
Sun Jan 15 23:09:45 CET 2006


2006/1/15, Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org>:
> On Monday, 12 September 2005 at 01:14, Dominik 'Rathann' Mierzejewski wrote:
> > On Monday, 12 September 2005 at 00:56, Guillaume POIRIER wrote:
> > > Hi,
> > >
> > > On 8/21/05, Wes Shull <wes.shull at gmail.com> wrote:
> > > > libXvMCW is a wrapper which dlopens a proper libXvMC at runtime (which
> > > > one it loads is configurable); it eliminates the need to link directly
> > > > against a hardware-specific xvmc lib to support it.
> > > >
> > > > The library originated in the Unichrome driver project (
> > > > http://unichrome.sourceforge.net/ ) but is useful for nvidia, etc.
> > > > too.  It's in ATrpms, probably other places too.
> > > >
> > > > Attached is a pretty simple mostly cut&paste patch to enable its use
> > > > with mplayer.  It adds an --enable-xvmcw (and --disable-xvmcw) option,
> > > > which must be used in conjunction with --enable-xvmc.
> > > >
> > > > The patch is directly against configure, from today's (anon) cvs,
> > > > which feels very wrong to me--it should be against configure.in.
> > > > Except I can't find that.
> > > >
> > > > This is my first patch submission to mplayer.  Flame away ;-)
> > >
> > > Do you have a new patch available that features Dominik's suggestions?
> >
> > And Ivan's.
>
> As it turns out, there's no need for your patch, Wes. All the support is
> already in place, we just need to make it autodetected and set the
> defaults, i.e. like the attached patch.
>
> I've tested it as far as the compilation goes, because I have no
> XvMC-capable cards at home, but it should work, as long as XvMCW works.
>
> Regards,
> R.

I'm against enabling xvmc by default. it is not generic usable yet. It
also slows down (by a tinny bit) the ffmpeg12 decoder.

Also, when linking statically we get benefit and shared memory
subpicture transfer.  As NVidia library is never installed as part of
Xorg it is quite safe to assume we want it. Same applies for some of
the other.

Please make it as hinted above, (with <for> loop and test for libraries).

Best Regards
  Ivan Kalvachev
  iive




More information about the MPlayer-dev-eng mailing list