[MPlayer-dev-eng] [PATCH] CFLAGS cleanups

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Fri Jan 13 23:35:49 CET 2006


This patch cleans up OPTFLAGS in Gui, removes hardcoded -Wall from
libaf's and libmenu's Makefiles and -g from main Makefile.
Now we can add -Wall to default CFLAGS and be sure it's used
consistently.

If nobody speaks up, I'll commit it tomorrow evening.

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
-------------- next part --------------
--- MPlayer-20060113/Gui/Makefile.nodebug	2004-11-01 15:47:51.000000000 +0100
+++ MPlayer-20060113/Gui/Makefile	2006-01-13 23:30:30.000000000 +0100
@@ -6,8 +6,7 @@
 
 INCDIR  = -I. -I.. -I../loader -I./wm -I./skin $(FREETYPE_INC) $(GTKINC) $(EXTRA_INC) 
 
-OPTIMIZE =  $(OPTFLAGS) \
-            -fexpensive-optimizations -fschedule-insns2 -Wall
+OPTIMIZE =  $(OPTFLAGS)
 
 CFLAGS = $(OPTIMIZE) $(INCDIR) $(DEBUG) 
 
--- MPlayer-20060113/libaf/Makefile.nodebug	2005-11-13 21:29:01.000000000 +0100
+++ MPlayer-20060113/libaf/Makefile	2006-01-13 23:29:24.000000000 +0100
@@ -38,7 +38,7 @@
 
 OBJS=$(SRCS:.c=.o)
 
-CFLAGS  = $(OPTFLAGS) -I. -I.. -Wall $(LIBAV_INC) $(EXTRA_INC) -D_GNU_SOURCE
+CFLAGS  = $(OPTFLAGS) -I. -I.. $(LIBAV_INC) $(EXTRA_INC) -D_GNU_SOURCE
 
 ifeq ($(TARGET_OS),MINGW32)
 CFLAGS += -D_IO_H_
--- MPlayer-20060113/libmenu/Makefile.nodebug	2004-07-09 21:22:35.000000000 +0200
+++ MPlayer-20060113/libmenu/Makefile	2006-01-13 23:29:24.000000000 +0100
@@ -10,7 +10,7 @@
 endif
 OBJS=$(SRCS:.c=.o)
 
-CFLAGS  = $(OPTFLAGS) -I. -I.. -I../libmpcodecs $(EXTRA_INC) -Wall
+CFLAGS  = $(OPTFLAGS) -I. -I.. -I../libmpcodecs $(EXTRA_INC)
 
 .SUFFIXES: .c .o
 
--- MPlayer-20060113/Makefile.nodebug	2006-01-02 21:50:34.000000000 +0100
+++ MPlayer-20060113/Makefile	2006-01-13 23:29:24.000000000 +0100
@@ -446,7 +446,7 @@
 $(MENCODER_DEP): version.h help_mp.h
 
 $(PRG_CFG): version.h codec-cfg.c codec-cfg.h
-	$(HOST_CC) $(HOST_CFLAGS) -I. -g codec-cfg.c mp_msg.c -o $(PRG_CFG) -DCODECS2HTML $(EXTRA_LIB) $(EXTRA_INC) $(I18NLIBS)
+	$(HOST_CC) $(HOST_CFLAGS) -I. codec-cfg.c mp_msg.c -o $(PRG_CFG) -DCODECS2HTML $(EXTRA_LIB) $(EXTRA_INC) $(I18NLIBS)
 
 install: $(ALL_PRG)
 ifeq ($(VIDIX),yes)


More information about the MPlayer-dev-eng mailing list