[MPlayer-dev-eng] [PATCH] printf warning fixes (REPOST)
Reimar at mplayerhq.hu
Reimar at mplayerhq.hu
Tue Jan 10 14:47:02 CET 2006
Hi,
> > 3) even though correct, I'm not sure if those %x -> %p changes are
> > desirable or if we should think up some other way.
>
> %x is for unsigned ints. %p is for pointers. Another way would be to cast the pointer
> to unsigned int, but what of the platforms where pointers are 64bit? %p is portable.
Yes, I know, it's just that it will look a bit different. Not a big
thing though.
> ve_vfw.c includes <wine/vfw.h>
> They are long:
>
> loader/wine/vfw.h
> typedef struct __attribute__((__packed__))
> {
> long biSize;
> long biWidth;
> long biHeight;
> short biPlanes;
> short biBitCount;
> long biCompression;
> long biSizeImage;
> long biXPelsPerMeter;
> long biYPelsPerMeter;
> long biClrUsed;
> long biClrImportant;
> } BITMAPINFOHEADER, *PBITMAPINFOHEADER, *LPBITMAPINFOHEADER;
This is absolutely wrong, it will have different sizes on 32 and 64 bit
architectures, someone please fix it and have a look out for more of
this kind of bugs.
Greetings,
Reimar Doeffinger
More information about the MPlayer-dev-eng
mailing list