[MPlayer-dev-eng] [PATCH] darwin dvd selection fix

Diego Biurrun diego at biurrun.de
Mon Jan 9 16:09:20 CET 2006


On Mon, Jan 09, 2006 at 11:50:00AM +0100, Emanuele Giaquinta wrote:
> 
> The attached patch fixes darwin dvd selection; it adds a call to UDFFindFile to
> verify that we are opening a valid udf image.  Note that this check is
> integrated in DVDOpen in the cvs version of libdvdread, so I added the
> preprocessor check to anticipate the upcoming release.

libdvdread is being worked on again?  Wow, that's great news.  Do you
know if they have incorporated our patches or would be interested in
accepting them?

Maybe it would be better to upgrade to their CVS version or the next
release if it is going to appear soon.

> It fixes the case when the dvd drive is associated to a rdiski, and
> a rdiskj exists with j < i; without this patch the demuxer will try
> to open rdiskj, since DVDOpen returns a valid dvdreader_t for it, and
> will fail after the call to ifoOpen.

Does it still work the other way around?  When the dvd drive is associated
to a rdiski, and a rdiskj exists with j > i?

Diego

P.S.: Is this the same patch you submitted some time ago?




More information about the MPlayer-dev-eng mailing list