[MPlayer-dev-eng] [PATCH] dvdnav

[Diego Biurrun]

On Tue, Jan 03, 2006 at 08:21:45PM +0100, Ötvös Attila wrote:
> 2006. január 2. 16.33 dátummal Diego Biurrun ezt írta:
> >
> > Do you plan on fixing these issues?
> 
> The dvdnav handler is bad in mplayer.c and in several case it passes in the 
> dvdnav event in the course of processing of the demuxer_seek(). 
> 
> I found out DVDNAV_STOP event error, that it happenes if at the given program 
> entry hasn't command table present.
> 
> The new dvdnav patch:
> 
> http://members.chello.hu/dc/mplayer/
> 
> Main modifications (compared with old patch):
> 
> - libdvdnav & dvdnav_stream were packed in the stream_dvdnav (so that cab be 
> used: --disable-mpdvdkit2 options)
> - dvdnav handle is an error and I corrected it in mplayer.c (demuxer_seek())
> - dvdnav STOP_EVENT is an error and I corrected it
> - remove demuxer->event structure

Here is some more feedback.

Compilation fails if Live555 (used to be called LIVE.COM) is enabled:

cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -g -O4   -maltivec
-mabi=altivec -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -I.. -I../loader
-I../libavutil -I../libavcodec -I../libavformat
-I/usr/local/live/liveMedia/include
-I/usr/local/live/UsageEnvironment/include
-I/usr/local/live/BasicUsageEnvironment/include
-I/usr/local/live/groupsock/include -o demux_rtp.o demux_rtp.cpp
stream_dvdnav.h:1053: error: expected ',' or '...' before 'this'
stream_dvdnav.h:1062: error: expected ',' or '...' before 'this'
make[1]: *** [demux_rtp.o] Error 1
make[1]: Leaving directory `/home/diego/src/mplayer/vanilla/libmpdemux'
make: *** [libmpdemux/libmpdemux.a] Error 2


Some more issues:

- Language selection does not appear to work.  When I select a different
  language in a menu, the movie does not start.
- Sometimes items in menus are highlighted if the mouse/cursor is above
  them, sometimes not.
- With gmplayer in the small movie that is played before the real menu
  comes up, if I move the mouse I get annoying "Not in a menu." error
  messages on the console *and* as popups.
- On startup with gmplayer I get the error message "Virtual DVD machine
  not started" or "Bad VM state." on the console and as popup.
- Some menus still fail to work at all.

I don't want to sound too negative, this revision is working much better
than the last one already, keep up the good work!

> (I am sorry to say that my English knowledge isn't good.)

Don't worry, it's perfectly acceptable.

Diego