[MPlayer-dev-eng] [PATCH] dvdnav

[Ötvös Attila]

2005. december 30. 13.42 dátummal Nico Sabbi ezt írta:

> Hi,
> I gave a quick look at libdvdnav.patch and navmplayer.patch, mainly
> hoping to restore
> support for dvdnav:// stream.
> IMO, In their current form  those patch can't be applied, these are my
> reasons:
> - why did you patch so extensively libmpdvdkit2? if it can't live with
> the current libdvdnav
> you had better change configure so that support for dvdnav be mutually
> exclusive with
> dvdread|mpdvdkit, otherwise libmpdvdkit2 will be impossible to read and
> to fix or keep in sync.
> If the reason is different explain it, please
>
> - the changes in demuxer.c in demuxer.c can't go in (recently we had a
> hard time modularizing and cleaning it);
> you had better implement those functionalities as a demuxer_ctrl()
>
> - I won't pronounce on the code in mplayer.c and in the files involved
> in decoding subs for obvious reasons :)
>
> Bye,
>
>     Nico

I created several private DVD by menu and I wanted to try out (before 
writing), but the mplayer couldn't be worked by dvdnav:// stream. So I 
created simple patch with mplayer. Later I fixed on  it so that the mplayer 
could use the majority of DVD buyed too. Because of these the plan wasn't 
manly during making of the patch, only it happened.

I can follow hard the development orientation of the mplayer because of my 
little english knowledge. My pleasuse I expect whatever prosposal, so that 
the dvdnav patch will be better.

New patch: libdvdnav & dvdnav_stream were packed in the stream_dvdnav (so that 
cab be used: --disable-mpdvdkit2 options)

http://members.chello.hu/dc/mplayer/

(I am sorry to say that my English knowledge isn't good.)

Best regards!

Attila