[MPlayer-dev-eng] Re: [PATCH] OSD localization third try

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 16 November 2005 at 21:12, Tobias Diedrich wrote:
> Reimar Döffinger wrote:
> 
> > On Mon, Nov 07, 2005 at 07:40:41PM +0100, Tobias Diedrich wrote:
> > > Well, the code enabled by this only deals with UTF8, other multibyte
> > > encodings are entirely different beasts.  I'll rewrite it to use
> > > iconv when I find the time (Maybe Wednesday).
> > 
> > Keep in mind that e.g. MinGW does not have iconv, so IMHO avoid it if at
> > all possible,
> 
> Ok, so how about a simple iconv implementation for osdep?
> See attached patch (Note: I know the configure check is lacking.
> i.e. IIRC at least on Solaris -liconv is needed).

Exactly. If you could fix it...
And please remove debugging code as well (especially main(), even if it is
#ifdef'd).

Regards,
R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"