[MPlayer-dev-eng] [PATCH] Making all vo globals local

[D Richard Felker III]

On Mon, Feb 28, 2005 at 01:14:57PM +0100, Reimar Döffinger wrote:
> Hi,
> On Mon, Feb 28, 2005 at 05:55:41AM +0100, Ivo wrote:
> > If you have any comments on this, please respond! If not, I'll start working 
> > on a huge patch that converts all vo's and video_out.c to this format :-)
> 
> I currently can't see any sense in this, it is just a huge "cosmetics"
> patch than in addition might (or actually will) have negative effects on speed...

Nonsense, nothing like this can affect speed. It's on a completely
different order of magnitude than the speed-relevant stuff. I was the
one who suggested changes like this (or at least not adding new
static/global vars in the vo's) because in the long term everything
should support multiple instances. Of course, libvo will probably be
replaced before then, but still we should be practicing good design.

Rich