[MPlayer-dev-eng] [PATCH] fixes for gcc4
D Richard Felker III
dalias at aerifal.cx
Sun Feb 27 19:22:48 CET 2005
On Sun, Feb 27, 2005 at 11:00:20AM +0100, Gianluigi Tiesi wrote:
> On Sat, Feb 26, 2005 at 10:56:50PM +0100, Michael Niedermayer wrote:
> > Hi
> >
> > On Friday 25 February 2005 20:43, Gianluigi Tiesi wrote:
> > > Updated patches to be compatible with gcc-2.95
> >
> > > + int ptr;
> >
> > very missleading name (an integer with name ptr)
> >
> >
> > > + ptr = ((int) src) + filterSize;
>
> you can use different name or use unsigned int since it should be equal
> to a pointer, here filterSize is an int and it's added to a pointer,
> also this sum should be wrong.
> Anyway this can be decared as a pointer but adding filterSize will cause
> compiler to complain, but I think this can be acceptable.
Nonsense. pointer = pointer + int; is totally valid C. Learn C if
you're going to patch C code... :)
Rich
More information about the MPlayer-dev-eng
mailing list