[MPlayer-dev-eng] [PATCH] MEncoder Multiple file 2 pass fix

Jindrich Makovicka makovick at kmlinux.fjfi.cvut.cz
Sun Feb 27 15:50:00 CET 2005


Oded Shimon wrote:
> On Saturday 26 February 2005 17:03, Jindrich Makovicka wrote:
> 
>>+        if ((vf->fmt.orig_width != width)
>>+           || (vf->fmt.orig_height != height)
>>+           || (vf->fmt.orig_fmt != outfmt)) {
>>+            mp_msg(MSGT_MENCODER,MSGL_FATAL,MSGTR_ResolutionDoesntMatch);
> 
> 
> Is "MSGT_MENCODER" really appropriate here?.. Wouldn't MSGT_VFILTER be more 
> appropriate?

yes, definitely. but maybe mencoder could eventually produce an 
additional explanatory message too (something like "failed to initialize 
image filters") instead of just dying when vf_inited < 0.

-- 
Jindrich Makovicka




More information about the MPlayer-dev-eng mailing list