[MPlayer-dev-eng] [PATCH] MEncoder Multiple file 2 pass fix

[D Richard Felker III]

On Sat, Feb 26, 2005 at 04:03:46PM +0100, Jindrich Makovicka wrote:
> Oded Shimon wrote:
> >This patch fixes MEncoder's handling with multiple files and the VE - 
> >instead of what was before, that the VE was completely uninited and then 
> >re-inited for each file, the VE stays the same the whole time and for that 
> >reason can now handle creating 2 pass files gracefully, and doesn't force 
> >a keyframe when switching between files, etc...
> >
> >Also the handling with a change between different files' resolution is 
> >different, the checking was moved to the VE, as keeping it in mencoder.c 
> >is impossible with new set up.
> >
> >Compiled and tested.
> 
> Can you please test this version? It adds another filter capability 
> (VFCAP_CONSTANT) and does the parameter check in one place instead of 
> copy&paste all over ve_*.
> 
> Regards,
> -- 
> Jindrich Makovicka

this is a much better solution, but the patch is slightly bad, imo.
your vf_config_wrapper duplicates the sort of purpose vf_next_config
is already there for. please just put the code in vf_next_config; then
it will be fine to commit.

rich