[MPlayer-dev-eng] Mplayer: PT_GNU_STACK RWE

[Dominik 'Rathann' Mierzejewski]

On Thursday, 24 February 2005 at 12:46, Ivan Gyurdiev wrote:
> On Thu, 2005-02-24 at 01:52 +0100, Reimar Döffinger wrote:
> >Hi,
> >On Wed, Feb 23, 2005 at 06:33:44PM -0500, Ivan Gyurdiev wrote:
> >> >Better just apply the attached patch. Binary codecs that do not run with
> >> >noexecstack also won't run on WinXPSP2 with "Data Execution Protection"
> >> >activated, so if the codec is still maintained there should be a codec
> >> >that works with it.
> >> 
> >> Excellent. The patch results in binaries that are marked PT_GNU_STACK
> >> RW. Is this patch for me alone, or are you going to merge it in 
> >> the mplayer source?
> >
> >I'd like to get it into CVS but I don't know if it might cause some
> >linkers to fail because of an unknown option. If so, a configure check
> >would be necessary - but I hate to write configure checks.
> >So I'd say it will be applied if somebody else takes care of it...
> 
> My version of ld has this, by the way:
> 
>   -z KEYWORD            Ignored for Solaris compatibility
> 
> It won't complain on nonsense -z values. 
> Not sure if this is relevant..

It is. What if we're compiling on Solaris with gcc built with native (not
GNU) binutils? I can't test this case right now, so I'm putting this as
food for thought.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"