[MPlayer-dev-eng] [PATCH] -slave-idle option

[Attila Kinali]

On Thu, 24 Feb 2005 19:04:50 +0200
Oded Shimon <ods15 at ods15.dyndns.org> wrote:

> A "bug" - using -fixed-vo causes a frozen window inbetween idling. I see no 
> way around this.

there is none that would be general
for x11 you could unmap the window and remap it again.

> @@ -4205,8 +4222,8 @@
>    }	
>  #endif
>  
> -if(use_gui || playtree_iter != NULL){
> -
> +if(use_gui || playtree_iter != NULL || slave_idle){
> +  if (!playtree_iter) filename = NULL;

I'm quite sure that this causes a memleak, but
i cannot say whether it's safe to free filename.
I dont understand playtree enough.
But actualy i'd say that play_tree_iter_get_file()
should strdup the filename it gives back so
the caller could free it. 

IMHO the playtree stuff could need some redesing
and documentation.

As discussed on irc, the parameter should be renamed to -idle

If nobody objects, i'll apply this within the next days
(i need it for some other work).

					Attila Kinali

-- 
郷に入れば郷に従え