[MPlayer-dev-eng] Mplayer: PT_GNU_STACK RWE

[Reimar Döffinger]

Hi,
On Wed, Feb 23, 2005 at 06:33:44PM -0500, Ivan Gyurdiev wrote:
> >Better just apply the attached patch. Binary codecs that do not run with
> >noexecstack also won't run on WinXPSP2 with "Data Execution Protection"
> >activated, so if the codec is still maintained there should be a codec
> >that works with it.
> 
> Excellent. The patch results in binaries that are marked PT_GNU_STACK
> RW. Is this patch for me alone, or are you going to merge it in 
> the mplayer source?

I'd like to get it into CVS but I don't know if it might cause some
linkers to fail because of an unknown option. If so, a configure check
would be necessary - but I hate to write configure checks.
So I'd say it will be applied if somebody else takes care of it...

Concerning security - well, non-executable stack might improve things a
bit but not much IMHO - there a things that help a lot more. And I had
the impression that SELinux is more effort than what makes sense to the
"average" user, so I assumed you might have a specific reason to use it,
thus the comments.

Greetings,
Reimar Döffinger