[MPlayer-dev-eng] New remove-logo filter

[D Richard Felker III]

On Wed, Feb 23, 2005 at 10:48:00AM -0500, Yartrebo wrote:
> On Wed, 2005-02-23 at 12:18 +0100, Reimar Döffinger wrote:
> > Hi,
> > On Wed, Feb 23, 2005 at 01:55:21AM -0500, Yartrebo wrote:
> > > Hi, and sorry, but I forgot one of the files in the diff patch. This one
> > > goes into libmpcodecs.
> > 
> > I really think you should simplify the code a lot. First of all I think
> > you should use raw grayscale instead of tga image, reading it in should
> > the need no more that around 6 lines.
> 
> The image is made using a graphics program, such as the GIMP. Asking for
> raw greyscale might be asking a bit too much. Internally it's stored
> using 8bpp, so all that's lost is some hard disk space. Also, having the
> width and height stored is very useful to make sure the image matches
> the video stream dimensions (that check will be in the next revision I
> submit).

i agree, raw grayscale is a stupid format. btw is there such thing as
grayscale tga?

> TGA is one of the simplest formats that doesn't suffer for the problems
> of raw data, so that's why I chose it. I could make the reader take 8-10
> lines of code, but then it wouldn't be safe if an unsupported type (say,
> RLE compressed) one was fed in.

what do you mean by "wouldn't be safe"? if it fails or exhibits
strange behavior, that's fine. just document that it needs raw
uncompressed tga.

rich