[MPlayer-dev-eng] [PATCH] to support unofficial toolame-02n-beta2
Nico Sabbi
nsabbi at tiscali.it
Wed Feb 23 10:37:32 CET 2005
Diego Biurrun wrote:
>Ibro writes:
>
>
>>this patch makes mplayer support the unofficial and header broken toolame-02n-beta2 from:
>>http://www.ecs.soton.ac.uk/~njh/toolame/toolame-02n-beta2.tar.gz
>>
>>
>
>And why exactly would we want to support such a thing?
>
>Diego
>
>
now that I've read the sources of that fork I agree with Diego: there's no
reason to apply Ibro's patch (at least most of it), because who forked
toolame
made some unexplainable things:
- renamed toolame_setX() to toolame_set_x() functions
- changed some enum ordering (MPEG1, MPEG2_LSF)
- renamed MONO, STEREO to MPG_MD_MONO and so on
- changed slightly the syntax of toolame_encode_buffer()
I don't know why he did so, but he can very easily add some macro
definition
to toolame.h to keep compatibility with the official libtoolame.
Some of the help code and some fix to the vbr encoding (currently not
working) may go in, though.
Patch (mostly) rejected.
Nico
More information about the MPlayer-dev-eng
mailing list