[MPlayer-dev-eng] [PATCH] liba52 float support

[Arpi]

Hi,

> D Richard Felker III wrote:
> > > > during all the processing, the audio becomes nothing but white noise.
> ...
> > I just fixed the bug, which was caused by missing prototype for
> > lrintf. Now it works.
> 
> So I assume this means that I can commit the -a52float changes?  The
> default will still be int, because it is still faster.  And speaking
> about speed, if we had a -a52volume switch, that would provide free
> volume control, and it would be much faster than using -a52float -af
> volume.  And since since speed is so important in mplayer that even a
> single register add immediate per sample is considered too expensive,
> I would think -a52volume could be desirable.  My machines are so fast
> that it does not really mater for me if I have that switch or not.

sure, but this kind of in-codec volume (and eq) setting support should be
done via controls (AF_CTRL_* or so), instead of commandline options
for every single codecs. this way the volume keys and irda etc could work...


A'rpi / MPlayer, Astral & ESP-team

--
Girls are like internet domain names, the ones I like are already taken.