[MPlayer-dev-eng] [PATCH] Set liba52 output volume

[Reimar Döffinger]

Hi,
On Tue, Feb 15, 2005 at 12:26:26PM -0500, D Richard Felker III wrote:
> On Tue, Feb 15, 2005 at 11:09:40AM +0100, Alex Beregszaszi wrote:
> > > > >The attached very simple patch adds a new option, -a52volume to set
> > > > >the output level from liba52.
> > > ...
> > > > sorry if this question is stupid, but does your patch have anything
> > > > to do with normalization or is it a different thing?
> > > 
> > > It's different, as the man page patch says, it is almost the same as
> > > using -af volume=<level>, except that it uses the float value before
> > > the int conversion.  Some DVDs have quite low audio levels, and
> > 
> > What? the af_volume stuff works on floats aswell, the problem lies in
> > ad_liba52, it should just output float (if that's the native format) and
> > let the filters do the conversion
> 
> rotfl!!! libaf's float support is 100% broken, all it does is output
> white noise! :))

I am not sure about that. I had the same problem as others described
with the musepack decoder, but at least for me they went away after
setting the sample size (could just be coincidence I have to admit).
Maybe removing the (now useless) data->bps checks/switch statements in
af_format will fix it finally.
I would be happy if somebody would come up with a patch for it :-)

Greetings,
Reimar Döffinger