[MPlayer-dev-eng] [PATCH] Bug fix for -geometry option NODAEMON

[Alexander Strasser]

Bjorn Danielsson wrote ( On Tue, Feb 01, 2005 at 11:35:03AM +0100 ):
> Diego Biurrun <diego at biurrun.de> wrote:
> > Bjorn Danielsson writes:
> > > The manual page says that "%" appended to an x or y position
> > > causes the corresponding value to be interpreted as a percentage
> > > of screen width/height instead of an absolute pixel offset.
> > > 
> > > The code doesn't agree, it applies this interpretation to both
> > > x and y even if only one of the coordinates has a "%" suffix.
> > > The attached patch makes the code agree with the manual, which
> > > in my opinion is more sensible in this case.
> > 
> > Rejected.  Your patch still has problems.  While it does fix some
> > cases, now e.g. -geometry 100%:50% does not work as it should anymore.
> 
> Ah, there were more subtleties than I recognized at first.
> Since sscanf reports successful assignments even when the trailing
> text doesn't match, the last % must always be explicitly matched
> and the matching order rearranged so the longest match is tried
> first. Here is an updated patch, which I have tested a bit more
> thoroughly (sorry about that).

Applied.

  Alex (beastd)