[MPlayer-dev-eng] [PATCH] Multiple files for MEncoder

[Alexander Strasser]

Oded Shimon wrote ( On Wed, Feb 09, 2005 at 01:04:31PM +0200 ):
> On Tuesday 08 February 2005 21:53, D Richard Felker III wrote:
> > On Tue, Feb 08, 2005 at 07:58:54PM +0200, Oded Shimon wrote:
> > > The only solution I can see is wrapping most of the stuff  in the initing
> > > in the begginning which isn't done twice around an 'if'. Not very
> > > elegant, but better than repetetive code I think.
> >
> > that would be ok too. probably better.
> >
> OK, I can do this, just one problem which usually leads to patches being 
> rejected - I'll have to reorganize mencoder.c a bit to make it more logical, 
> separate input initialization from output initialization. Either that or have 
> the 'if's pretty scattered around.
> One thing I'm noticing for ex. is this:
> 
> demuxer open
> vob sub out init
> subdata open
> muxer open
> 
> so I'd like to re-arrange that to make subdata open before the sub out init...

Well, make a seperate patch for it that does only the reodering and wait for
the reactions. It is much more likely someone will look at it if you don't
mix up things.

> Or maybe i will go for the struct idea?.. That one was pretty good.

IMHO it is not that of a good idea. Not saying that stuffing up things in
structs is generally a bad thing, but in this case I am not sure it will
yield any benifit over making it global. For it to become usefull there
would be much more work needed. So at least I am against just randomly
putting things in a struct for now.
But feel free to give arguments as I didn't have a close look at the problem.

  Alex (beastd)