[MPlayer-dev-eng] [PATCH] dvdnav

[Nico Sabbi]

Ötvös Attila wrote:

>Hi All.
>
>I am created a patch mplayer and gmplayer to using dvd menu.
>
>Implemented:
>- still frame menu (partially)
>- spu menu buttons (partially)
>- can be used mouse with menu selection (partially)
>- simple light box menu button (new OSDTYPE)
>- time length of vts domain stream
>- can be selection the subtitle language with "vobsub_lang" command ('j')
>- can be dvd menu trought set audio and subtitle languages
>- new menu item in gmplayer (in gtk menu)
>- can be set dvd menu languages
>
>The patch is big (185 kbyte), hence donwload this about link:
>
>http://members.chello.hu/dc/mplayer/
>
>(I am sorry to say that my English knowledge isn't good.)
>
>Best regards!
>
>Attila
>  
>

Hi,
I gave a quick look at libdvdnav.patch and navmplayer.patch, mainly 
hoping to restore
support for dvdnav:// stream.
IMO, In their current form  those patch can't be applied, these are my 
reasons:
- why did you patch so extensively libmpdvdkit2? if it can't live with 
the current libdvdnav
you had better change configure so that support for dvdnav be mutually 
exclusive with
dvdread|mpdvdkit, otherwise libmpdvdkit2 will be impossible to read and 
to fix or keep in sync.
If the reason is different explain it, please

- the changes in demuxer.c in demuxer.c can't go in (recently we had a 
hard time modularizing and cleaning it);
you had better implement those functionalities as a demuxer_ctrl()

- I won't pronounce on the code in mplayer.c and in the files involved 
in decoding subs for obvious reasons :)

Bye,

    Nico