[MPlayer-dev-eng] [PATCH] fix dvdread version macro in stream_dvd.c

Diego Biurrun diego at biurrun.de
Tue Dec 27 15:18:28 CET 2005


On Tue, Dec 27, 2005 at 11:54:46AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 27 December 2005 at 10:16, Emanuele Giaquinta wrote:
> > 
> > The attached patch to stream_dvd.c makes more consistent the
> > definition of the macro for the libdvdread version.  Starting from
> > libdvdread 0.9.4 dvd_reader.h defines a DVDREAD_VERSION macro, but
> > currently it is redefined in stream_dvd.c by a macro with the same
> > name used to calculate the version number given the major, minor and
> > micro numbers.  I need it to check, for my upcoming patch to fix
> > dynamic dvd drive
> > selection on darwin, that we have a version less or equal to 0.9.4,
> > which is currently impossible.
> 
> Funny, I was going to submit exactly the same patch at one point. ;)
> It shuts up a few "... redefined" warnings at the same time.

I'll leave you the honor of committing then.

Diego




More information about the MPlayer-dev-eng mailing list