[MPlayer-dev-eng] [PATCH] possible vo_cvidix bug

[Oded Shimon]

On Mon, Dec 26, 2005 at 11:42:01AM +0100, Sascha Sommer wrote:
> > ----- Forwarded message from Oded Shimon <ods15 at ods15.dyndns.org> -----
> >
> > When using vo_cvidix on matrox, colorkey setting doesn't work right, it
> > seems to apply only after switching to full screen. By hacking the code I
> > found that it only works if you change the colorkey BEFORE calling
> > vidix_init, not after. Because it was changed after, it was only applied
> > when calling vidix_init again (like to change resolution for a full screen
> > switch). With this patch, it works perfectly
> >
> > I am not maintainer of this and do not truely understand the change I made,
> > so I will not commit this unless approoved by someone who does... So,
> > someone please look over this patch...
> 
> Do you own a matrox card?

Yes, it's the reason I made this patch and the reason I pushed you to check 
it. I didn't want the global MPlayer installed on my system to be a hacked 
MPlayer.

> I'm against this change as it is only a workaround. I just looked over all the 
> other drivers and they seem to write the new colorkey to the registers when 
> the vixSetGrKeys function gets called.
> You could try to seperate the colorkey part of mga_vid_write_regs function and 
> then call this from vixSetGrKey, too.
> As quick alternative something like the attached patch might also work.

I was feeling my patch might be wrong.
The patch you sent works perfectly. Should I commit it?...

- ods15