[MPlayer-dev-eng] [PATCH] "staying" and "aletrnating" input prefixes

Oded Shimon ods15 at ods15.dyndns.org
Sun Dec 25 20:23:40 CET 2005


On Sun, Dec 25, 2005 at 06:37:04PM +0200, Oded Shimon wrote:
> On Sun, Dec 25, 2005 at 03:24:39PM +0100, Reimar Döffinger wrote:
> > Hi,
> > On Sun, Dec 25, 2005 at 08:52:22AM +0200, Oded Shimon wrote:
> > > along with "pausing", this patch bring 2 new input prefixes, "staying" and 
> > > "alternating". "staying" causes mplayer to pause if it was already paused 
> > > when command was given, and not otherwise. "alternating" does the exact 
> > > opposite.
> > > Addmittedly, "alternating" is rather odd, but believe it or not I actually 
> > > do have a use for it... And it's not a big deal to implement, so why not. :)
> > 
> > I'd prefer them to be named something like pausing_keep and
> > pausing_toggle, it pollutes the "namespace" less.
> > Also if we ever make an alphabetical list of prefixes they will be close
> > together.
> 
> Fair enough, I think that's a good idea. New patch here. Also documentation 
> suggestion by The Wanderer.
> 
> > btw. about that was_.. variable, isn't there already some other variable
> > that keeps track of the paused state? Adding another one makes it likely
> > that they will get out of sync after a few broken patches *g*
> 
> I see no such variable. There is no flag I can see anywhere in the entire 
> 60 line code handling PAUSE... Will commit soon.

committed

- ods15




More information about the MPlayer-dev-eng mailing list