[MPlayer-dev-eng] [PATCH] bad configure detection for termcap

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Sun Dec 25 14:07:44 CET 2005


On Saturday, 24 December 2005 at 20:58, Oded Shimon wrote:
> Termcap detection is incomplete, on my system using -lncurses for termcap 
> also works. If noone speaks up, I'll commit tommorrow.
> 
> - ods15

> Index: configure
> ===================================================================
> RCS file: /cvsroot/mplayer/main/configure,v
> retrieving revision 1.1111
> diff -u -r1.1111 configure
> --- configure	14 Dec 2005 21:52:40 -0000	1.1111
> +++ configure	24 Dec 2005 19:57:42 -0000
> @@ -3060,10 +3060,10 @@
>  echocheck "termcap"
>  if test "$_termcap" = auto ; then
>    cat > $TMPC <<EOF
> -int main(void) { return 0; }
> +int main(void) { tgetent(); return 0; }
>  EOF
>    _termcap=no
> -  for _ld_tmp in "-ltermcap" "-ltinfo" ; do
> +  for _ld_tmp in "-ltermcap" "-ltinfo" "-lncurses"; do

I'd prefer to change the detection order, i.e. ncurses first, then fall back
to tinfo and finally termcap. ncurses and terminfo are superior to the old
termcap.

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"




More information about the MPlayer-dev-eng mailing list