[MPlayer-dev-eng] [PATCH] mute audio on NetBSD with sun audio output driver

[Alexander Becher]

Diego Biurrun schrieb:
>On Thu, Dec 22, 2005 at 01:50:01AM +0100, Alexander Becher wrote:
>> 
>> Since revision 1.19 of the file libao2/ao_sun.c, muting is as follows:
>> mixer volume is not changed, only a mute flag is set, which does not
>> exist on NetBSD (nor on OpenBSD to my knowledge). Therefore, muting has
>> no effect. With the attached patch, when the volume levels are
>> requested to be set to zero, they are changed in addition to the mute
>> flag being set.
>
>I'm not sure this is a good solution since now the volume is set to zero
>unconditionally.  On a system that supports a mute flag, using it is
>preferrable to zeroing the volume.  Of course if it does not exist,
>there is no alternative...

Good point. I should probably surround the if (...) statement with a
#if !defined(...), so the volume is zeroed only when there is no other
choice. I will change the patch accordingly and resend it.

Regards
Alexander
-- 
PGP key available
Port Payé / Entgelt bezahlt / Postage Paid: http://www.hashcash.org/