[MPlayer-dev-eng] [PATCH] Warning fixes for mplayer.c

[The Wanderer]

On 12/19/2005 05:21 AM, Diego Biurrun wrote:

> On Mon, Dec 19, 2005 at 11:18:03AM +0100, Dominik 'Rathann'
> Mierzejewski wrote:
> 
>> On Saturday, 17 December 2005 at 20:52, Oded Shimon wrote:
>> 
>>> warning fixes for mplayer.c, mostly printf '%d' for 'long' type
>>> stuff,
>> 
>> I've already submitted a patch fixing all of them, not only in
>> mplayer.c.
> 
> But did you commit it?  Somebody please do...

It was submitted on November 27th, and has not been committed. However,
there was enough "this should probably be done differently" discussion
in response to the patch that I'm reluctant to commit it as-is.

(I'm 'way too far behind on the patch backlog, even just in my own
records much less the ones I inherited - which is partly because I
suspect that flooding the list with too many "comments?" posts would
just mean none of them would get responses... and the current backlog of
"comments?" posts is getting long enough as it is.)

Speaking of compiler warnings, I'm recently getting varyingly minor
floods of "pointer targets in passing argument # of function_name differ
in signedness" warnings throughout the code. I suspect that this is
because of a recent 'upgrade' to gcc, which I didn't consciously notice
I was making (part of a mass "clean up and clean out my installed
packages" project); I'm currently compiling with a gcc 4.0.3 prerelease
from the first of the month. Is it worth trying to modify the code to
remove these warnings (not that I have the faintest idea how that might
be done), and if not, to what version should I most likely 'downgrade'?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.