[MPlayer-dev-eng] [PATCH] deobfuscate vf_scale

[Oded Shimon]

On Sat, Dec 17, 2005 at 07:13:36PM -0500, Rich Felker wrote:
> On Sat, Dec 17, 2005 at 09:36:33PM +0200, Oded Shimon wrote:
> > Just found this old patch I made, this code is completely unnecessarily 
> > obfuscated, small patch here makes it much more readable and keeps same 
> > behavior.
> > The actual behavior preserved here, to all the 0, -1, -2, and -3 options in 
> > vf_scale, you can add -8 (so, -8, -9, -10 and -11) to get rounding.
> > 
> > Is anyone against this?.. Compiled and tested, works fine.
> 
> This is broken. The idea was to treat 8 as a bitflag so that more
> flags could be added in the future. Your senseless change breaks that!

Oh, I totally missed that... Should I revert then?
IMO we shouldn't put these flags into numbers, we should make more options 
for vf_scale, so you can do 'scale=-2:-2:round=1' instead.

- ods15