[MPlayer-dev-eng] [PATCH] real muting

[The Wanderer]

Reimar Döffinger wrote:

> Hi,
> the attached patch implements real muting (i.e. the audio device gets
> paused).
> It currently disables the "set volume to 0" part, too, this probably
> should be an option (suggestions for name + values?).
> Please test it, I'm sure it will cause problems in some cases, e.g.
> with -ao alsa the movie makes a short skip forward when muting.

I've just tested this patch, and it seems to work fine for the most
part.

As you note, the video runs forward at high speed for a moment when
toggling mute on with -ao alsa. With any other AO method I've tried,
however (oss, sdl, nas - those being the only others that work for me
right now), although there is no high-speed skip when toggling mute on,
there *is* a skip of varying length (apparently depending, at least in
part, on which AO method was used) when toggling it *off*. My first
guess would be that this is done as part of maintaining A/V sync,
although I'm not sure why it would have that effect (the behaviour of
audio vs. video when framestepping comes to mind for some reason...)

I'd like to be able to have true muting available, although I'm not sure
how much I'd use it in practice, but I don't think the side effects of
this patch in its current form are worth it.

Any other opinions?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.