[MPlayer-dev-eng] Four small patches addressing build problems (fwd)

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 14 December 2005 at 10:24, Peter Breitenlohner wrote:
> On Tue, 13 Dec 2005, Dominik 'Rathann' Mierzejewski wrote:
> 
> >On Wednesday, 07 December 2005 at 09:42, Peter Breitenlohner wrote:
> >
> >>	Avoid gcc warnings:
> >>		'...' might be used uninitialized in this function
> >>
> >>	I think, in this case 'H', 'N', 'D', and 'F' can indeed be
> >>	used unitialized, thus possibly causing all sorts of problems.
> >>
> >Resend without cosmetics (whitespace changes).
> Here it is
> 
> >What does it actually do, remove one parenthesis?
> Replace something like
>  	if (expr_1) {
>  	  ...
>  	  create menu items H, N, D, and F
>  	}
>  	if (expr_2) {
>  	  make menu items H, N, D, and F insensitive
>  	}
> by
>  	if (expr_1) {
>  	  ...
>  	  create menu items H, N, D, and F
>  	  if (expr_2) {
>  	    make menu items H, N, D, and F insensitive
>  	  }
>  	}
> I don't know if there can be situations where expr_1 is false but
> expr_2 is true. If so, the originally code is buggy, otherwise the change
> doesn't harm.

Looks good to me, but I'm not the maintainer of the GUI code. Anyone? ;)

> >This is due to broken libjpeg.
> Yes, sort of. The actual culprit might be autoconf with the change in the
> generated headers ("#define HAVE_STDDEF_H" for version<=2.13 vs. "#define
> HAVE_STDDEF_H 1" for version>=2.49).
> 
> >We don't work around others' bugs.
> Fair enough.

Thanks a lot for bearing with me. ;)

Now if somebody bold enough would apply this to that rotten piece of code
that we call MPlayer GUI... ;)

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"