[MPlayer-dev-eng] [SURVEY] change mencoder's default ofilename extension?

[Reynaldo H. Verdejo Pinochet]

On Wed, Dec 14, 2005 at 10:19:05AM +0100, Reimar at mplayerhq.hu wrote:
> Hi,
> > +	extension=strrchr(out_filename,'.');
> > +	if (extension != NULL && strlen(extension) > 1)
> 
> I don't think the > 1 check is really necessary, though I do not mind
> it.

Its just to skip subsequent checks on output filenames named like foo.,
foo.., foo...., foo.bar., etc. While Answering to you I just realized it must
even be 3 < strlen(extension) < 6  ( .XXX  .XXXX )

> 
> > +		if (out_file_format == MUXER_TYPE_AVI)
> 
> Hmmm... would a switch/case work here? I'd say it would be easier to
> extend... 

Sure.

> Also, another idea would be adding a check_extension function
> to the muxers, maybe we could even support libavformat correctly with
> that *g* (but maybe not worth the effort)

who knows, IMHO is not worth the effort.

> 
> Greetings,
> Reimar Döffinger

Best regards

   Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20051214/c6066081/attachment.pgp>