[MPlayer-dev-eng] Re: [PATCH] print appropriate error when failing to open a file

[Tobias Diedrich]

Rich Felker wrote:

> > No need to switch to gettext for that, as soon as we do
> > "setlocale(LC_MESSAGES, "");" strerror will return a localized
> > message.
> 
> The problem is that setlocale is banned in MPlayer for good reason.
> It's a completely broken approach to handling locale.

AFAIK the only issues MPlayer had with setlocale was because of
LC_NUMERIC affecting scanf.
But since you can selectively only use LC_MESSAGES if you want to,
I don't really see a problem there, banning setlocale completely is
a bit of an overreaction IMHO.

And at least the unix locale handling is much better than the
windoze solution.

At the moment MPlayer's locale handling is _very_ lacking, since you
can't change character encoding or message language at runtime.

-- 
Tobias						PGP: http://9ac7e0bc.uguu.de